Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add per-server forwarding configuration in Velocity #453

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add per-server forwarding configuration in Velocity #453

wants to merge 3 commits into from

Conversation

Timongcraft
Copy link
Contributor

@Timongcraft Timongcraft commented Jul 22, 2024 •
edited
Loading

Reflect changes from Velocity#1357.

Prequirement:

  • This PR requires Velocity#1357 to be merged before this one can be finalized.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 6221dfc

powercasgamer
powercasgamer suggested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have examples, ans show how to migrate from before to the new format.

@Timongcraft
Copy link
Contributor Author

Should have examples, ans show how to migrate from before to the new format.

Where would you suggest a migration guide should be added?
Should it be included directly in the forwarding guide, or would it be better to use /velocity/migration, even though it seems rather unused?

@Timongcraft
Copy link
Contributor Author

@powercasgamer, do you think this is good?

@Timongcraft Timongcraft marked this pull request as ready for review July 24, 2024 23:14
@Timongcraft
Copy link
Contributor Author

Timongcraft commented Jul 24, 2024 •
edited
Loading

The 'blocked by feature' label should be removed, as it is no longer blocked.

@Nacioszeczek
Copy link
Member

The 'blocked by feature' label should be removed, as it is no longer blocked.

The Velocity PR is not merged.

@Timongcraft
Copy link
Contributor Author

The 'blocked by feature' label should be removed, as it is no longer blocked.

The Velocity PR is not merged.

You're right, I messed up.

@Timongcraft Timongcraft changed the title feat: Add per-server forwarding configuration feat: Add per-server forwarding configuration in Velocity Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powercasgamer powercasgamer powercasgamer requested changes

@zlataovce zlataovce zlataovce requested changes

Assignees
No one assigned
Labels
blocked by feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Timongcraft @Nacioszeczek @zlataovce @powercasgamer