full support for UnixDomainSocket backend #1173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coloryr
changed the title
|
Seems to already be in 5.0.0 as was done in #991 ? |
It's look like change the bind, instead of backend support |
|
My modification is for the |
|
My idea is |
| StringBuilder data = new StringBuilder().append(proxyPlayer.getVirtualHost().orElseGet(() -> | ||
| registeredServer.getServerInfo().getAddress()).getHostString()) | ||
| .append('\0') | ||
| StringBuilder data = new StringBuilder().append(getRemoteAddress()) |
There was a problem hiding this comment.
this changes the intended behavior here
There was a problem hiding this comment.
unix socket hoststring like /xxx/xxx is a filename, but inetsocketaddress.getHostString is a ipaddress, because of these two differences, resulting in different behaviors?
| // String playerVhost = | ||
| // proxyPlayer.getVirtualHost().orElseGet(() -> registeredServer.getServerInfo().getAddress()) | ||
| // .getHostString(); | ||
| String playerVhost = getRemoteAddress(); |
| @@ -25,6 +25,8 @@ | |||
| import io.netty.channel.epoll.EpollEventLoopGroup; | |||
| import io.netty.channel.epoll.EpollServerSocketChannel; | |||
| import io.netty.channel.epoll.EpollSocketChannel; | |||
| import io.netty.channel.epoll.EpollDomainSocketChannel; | |||
There was a problem hiding this comment.
epoll is epoll, we can't just slap it on every single connection type, that is not how that works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support paper backend with UnixDomainSocket
Is must work with this
refer to #991