Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log console command executions #1137

Open
wants to merge 1 commit into
base: dev/3.0.0
Choose a base branch
from

Conversation

Joo200
Copy link
Contributor

@Joo200 Joo200 commented Nov 5, 2023

Currently command executions are only logged for players. Imo this config option should include the console because not every command has a sender feedback and it could be nice to see it in the logs.

@novitpw
Copy link

novitpw commented Nov 13, 2023

And what commands may not have a feedback the sender? Don't you think this is already a plugin problem?

@Joo200
Copy link
Contributor Author

Joo200 commented Nov 14, 2023

And what commands may not have a feedback the sender? Don't you think this is already a plugin problem?

Yes, plugins should provide feedback but depending on the command there is none or not enough feedback to know which command was executed. Why should a plugin repeat the executed command, the executor already know the command.

So no, that's not directly a plugin issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants