Make CommandSourceStack respect hidden players

[notTamion]

fixes #11545

[lynxplay]

We have this diff already

Paper/patches/server/0988-Fix-entity-type-tags-suggestions-in-selectors.patch

Lines 80 to 92 in 85c870e

	+ // Paper start - tell clients to ask server for suggestions for EntityArguments
	+ final Collection<String> collection;
	+ if (icompletionprovider instanceof CommandSourceStack commandSourceStack && commandSourceStack.getEntity() instanceof ServerPlayer sourcePlayer) {
	+ collection = new java.util.ArrayList<>();
	+ for (final ServerPlayer player : commandSourceStack.getServer().getPlayerList().getPlayers()) {
	+ if (sourcePlayer.getBukkitEntity().canSee(player.getBukkitEntity())) {
	+ collection.add(player.getGameProfile().getName());
	+ }
	+ }
	+ } else {
	+ collection = icompletionprovider.getOnlinePlayerNames();
	+ }
	+ // Paper end - tell clients to ask server for suggestions for EntityArguments

Either we remove this or duplicate it.
Idk what else calls this method and if that is of interest to maybe not solve as deep.

[notTamion]

its only called by argument types so i think fixing this that deep is the correct solution.

[lynxplay]

Okay, thanks for the quick check 👍

[lynxplay]

While this works, we should probably at least discuss if we want certain commands to obey this visibility.
Banning and deop both sounds like commands where I'd never like this command to not show me the members?

[notTamion]

Perhaps we can add an exclusion for operators?

[Leguan16]

I think excluding operators makes sense.

[notTamion]

just an idea, if anyone has a solution they find better please leave a comment

[Machine-Maker]

I don't like making more functionality dependant on ops. The concept of "op" is not a good thing to really encourage more. People should be using proper permissions. I thought about maybe a new permission that could be granted to bypass all visibility hiding, but I'm not sure about that either.

[Leguan16]

I don't know. The paper command for example also works for ops and mixing op and permission requirements sucks.

[notTamion]

i agree with machine, considering servers will most likely not give staff operator but instead give them the permissions they need i think it would be smarter to add a permission for this. i don't think comparing this to the paper command is fair as the paper command is more of a debug command rather than something a staff member would actually have to use frequently

[Machine-Maker]

Ok, I think we want a permission, but just for command suggestions, paper.bypass-visibility.tab-completion