Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPEs:
Codec/item validation:
This often kick the player holding the bad item instantly without saving the last data.
ItemMeta bad equality:
This breaks the contract of equals that say x.equals(y) == y.equals(x)
Misc:
Known issues (unfixed):
- No way to set some components: base_color (shield), intangible_projectile (for crossbow, in charged_projectiles component), tool, debug_stick_state etc...- The LeatherArmorMeta fallback to the default leather color even for wolf armor which doesn't make sense
- Shield with base_color component gets an empty banner_patterns components once moved into the inventory
Opened this as a draft since there are more stuff to check