Fix CraftMetaBlockState for data components #10731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
added
the
build-pr-jar
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
from
3501675
to
279a7c2
Compare
electronicboy
approved these changes
May 17, 2024
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
from
279a7c2
to
664d187
Compare
|
I found some more issues related to the beehive thing. the fix for that in this PR currently isn't correct and only fixes one instance of it. Fixing all of them will require more diff so am going back to draft until I get that done. |
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
from
664d187
to
bcac3b0
Compare
Machine-Maker
changed the title
|
Ok, I think this is now the most correct fix for block entities and itemmeta. Instead of storing the data in a CraftBlockEntityState which will add a bunch of extra stuff, this changes it to 2 fields for the custom data and the rest of the components that apply to the specific block entity type. |
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
from
bcac3b0
to
7968ff8
Compare
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
2 times, most recently
from
029a960
to
575451b
Compare
kennytv
added
the
priority: high
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
2 times, most recently
from
d0fe354
to
878c55a
Compare
This will go on forever...
Machine-Maker
force-pushed
the
fix/ItemMeta-AGAIN
branch
from
878c55a
to
198efa6
Compare
lynxplay
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will go on forever...
Upstream's "restorePatch" function doesn't actually apply the patch which will compare the patch values to the itemtype's implicit values and not include the component if they equal. This fixes #10697.
Download the paperclip jar for this pull request: paper-10731.zip