Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standard semantic release rules #126

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Nov 29, 2023

Description

Remove the custom release version calculation rules: feat -> patch, braking -> minor, feat(MAJOR) -> major.

Motivation and Context

There were no braking changes recently, we can assume the code is major enough not to produce tons of major versions.
We also need to align the rules for calculating releases with pan-os-ansible project.

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
919 904 98% 95% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: dc88d6e by action🐍

Copy link

A Preview PR in PanDev repo has been created. You can view it here.

@alperenkose
Copy link
Collaborator

Shall we wait for the #128 merge which would be a breaking change before merging this?

@alperenkose alperenkose merged commit 801b9ac into main Aug 9, 2024
8 checks passed
@alperenkose alperenkose deleted the return-to-standard-semantic-release-rules branch August 9, 2024 08:24
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants