Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XPU] Support empty_cache on XPUs #9802

Open
wants to merge 2 commits into
base: release/3.0-beta2
Choose a base branch
from
Open

[XPU] Support empty_cache on XPUs #9802

wants to merge 2 commits into from
+64 −20

Conversation

will-jl944
Copy link
Contributor

@will-jl944 will-jl944 commented Jan 21, 2025 •
edited
Loading

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

New features

PR changes

APIs

Description

Support empty_cache on XPUs

wawltor
wawltor reviewed Jan 21, 2025
View reviewed changes
paddlenlp/utils/memory_utils.py Outdated
elif paddle.device.is_compiled_with_xpu():
paddle.device.xpu.empty_cache()
else:
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里增加打印下warning日志是不是更好点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

wawltor
wawltor approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@will-jl944 @wawltor