fix(resolver): do not copy sort when flattening a join or append transform #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sform closes PRQL#4063 PRQL#4947 Signed-off-by: Luka Peschke <[email protected]>
2 tasks
|
Hi @lukapeschke and thanks a lot for the contribution! I think this is correct. Paging @aljazerzen in case he knows of any corner cases this doesn't account for. Would you like to add to the changelog with attribution? |
Signed-off-by: Luka Peschke <[email protected]>
for more information, see https://pre-commit.ci
|
Thanks for the quick response @max-sixty ! I updated the changelog in 451ad58 🙂 |
|
Great! I will merge now and then if @aljazerzen has thoughts we can adjust. Welcome to PRQL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4063 #4947