Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dotnet targets #3791

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6864fe0
chore: add edition settings
Seddryck Nov 12, 2023
de79628
build: move build settings to props and targets
Seddryck Nov 12, 2023
b9d82c3
refactor: improve function descriptions and exception messages
Seddryck Nov 12, 2023
bc12ed9
fix: update name of the native dll to import
Seddryck Nov 12, 2023
2f85dc0
refactor: make PrqlCompilerOptions immutable
Seddryck Nov 12, 2023
eca84f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 12, 2023
a2c124d
Merge branch 'PRQL:main' into dotnet-targets
Seddryck Nov 12, 2023
891c704
Merge branch 'main' into dotnet-targets
max-sixty Nov 17, 2023
800f541
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 17, 2023
ae0aa9f
ci: github-action for building, testing and packaging in .NET
Seddryck Nov 19, 2023
235951e
fix: explicitely run the script setting the version
Seddryck Nov 19, 2023
bada233
fix: syntax issue
Seddryck Nov 19, 2023
fe70d3a
fix: cargo invocation
Seddryck Nov 19, 2023
e67b2c7
fix: new attempt
Seddryck Nov 19, 2023
ab70454
fix: finally understood that default shell is powershell :-/
Seddryck Nov 19, 2023
4357236
style: switch to file-scoped namespace
Seddryck Nov 19, 2023
3765846
fix: no clue
Seddryck Nov 19, 2023
0343340
fix: change jq
Seddryck Nov 19, 2023
c7c6d4f
fix: add reference to GitHubActionsTestLogger
Seddryck Nov 19, 2023
d60c635
fix: package command for CMD shell
Seddryck Nov 19, 2023
edb5735
style: fix trailing spaces reported by linter
Seddryck Nov 19, 2023
003c1cd
fix: attemp to make package downloadable to check it
Seddryck Nov 19, 2023
7bca705
style: prettier test-dotnet.yaml
Seddryck Nov 19, 2023
1092829
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 19, 2023
18c0bb4
Merge branch 'main' into dotnet-targets
Seddryck Nov 19, 2023
d767684
refactor: try to use the bash script
Seddryck Nov 19, 2023
b30c3ee
Merge branch 'dotnet-targets' of https://github.com/Seddryck/prql int…
Seddryck Nov 19, 2023
1bb0ca4
style: switch end of line to lf to match with .gitignore
Seddryck Nov 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/test-dotnet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
- name: 📂 Checkout code
uses: actions/checkout@v4
- name: 🏗 Build prqlc-clib
run: cargo build --package prqlc-clib --release

Check failure on line 14 in .github/workflows/test-dotnet.yaml

View workflow job for this annotation

GitHub Actions / lint-megalinter / lint-megalinter

14:56 [trailing-spaces] trailing spaces
- name: 🔢 Set version
run: ./.github/workflows/scripts/set_version.sh
- name: 🐜 Debug CI/CD (version)
run: echo $version
run: |
$version = cargo metadata --format-version=1 --no-deps | jq --raw-output '.packages[] | select(.name == "prql-compiler") | .version'
echo "version=$version" >> $env:GITHUB_ENV
Seddryck marked this conversation as resolved.
Show resolved Hide resolved
- name: 🐜 Debug CI/CD (version + target/release)
shell: pwsh
run: |
Expand All @@ -29,18 +29,21 @@
7
- name: 🛠️ Build
working-directory: prqlc/bindings/dotnet
shell: cmd
run: |
dotnet build prql-net.sln -p:version="%version%" -c Release /p:ContinuousIntegrationBuild=true --nologo
- name: 🧪 Test
working-directory: prqlc/bindings/dotnet
shell: cmd
run: |
dotnet test PrqlCompiler.tests\PrqlCompiler.Tests.csproj -c release --runtime win-x64 --logger GitHubActions /p:CI=true --nologo
- name: 📦 Package
working-directory: prqlc/bindings/dotnet
shell: cmd
run: |
dotnet pack PrqlCompiler -p:version="%version%" -c Release --include-symbols /p:CI=true --no-build --nologo
dotnet pack PrqlCompiler -p:version="$version" -c Release --include-symbols /p:CI=true --no-build --nologo
# - name: 🚚 Publish
# working-directory: prqlc/bindings/dotnet
# run: |
# dotnet nuget push PrqlCompiler/bin/Release/*.nupkg -k $NUGET_AUTH_TOKEN -s https://api.nuget.org/v3/index.json
# env:
Expand Down
Loading