Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xlsx.php (fix overwriting drawingX.xml) #3745

Closed
wants to merge 1 commit into from

Conversation

deadfire24
Copy link

Fix overwriting file xl/drawings/drawingX.xml if already exist by merging content

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

To use media and drawings at the same time by protecting against overwriting xl/drawings/drawingX.xml

Fix overwriting file xl/drawings/drawingX.xml if already exist by merging content
@deadfire24 deadfire24 changed the title Update Xlsx.php (fix overwriting drawingX.xml Update Xlsx.php (fix overwriting drawingX.xml) Sep 21, 2023
@oleibman
Copy link
Collaborator

Aside from the php-cs-fixer, phpcs, and phpstan errors, all of which you will have to fix, I do not understand your use case. What is the problem you are trying to solve? Have you opened an issue for it? And, although it is probably premature to start on this until the other items are addressed, you will need a formal test case to demonstrate that it works as intended. For now, I am converting this PR to a draft.

@oleibman oleibman marked this pull request as draft September 28, 2023 17:14
@oleibman
Copy link
Collaborator

No update in over 6 months. Closing.

@oleibman oleibman closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants