Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xlsx.php #3520

Closed
wants to merge 1 commit into from
Closed

Update Xlsx.php #3520

wants to merge 1 commit into from

Conversation

riverdale74
Copy link

Handle "default" cases by creating an empty string table entry.

I added these lines after observing that $sharedStrings was being indexed incorrectly with a test xlsx file. Adding these lines fixes that error.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Handle "default" cases by creating an empty string table entry.

I added these lines after observing that $sharedStrings was being indexed incorrectly with a test xlsx file. Adding these lines fixes that error.

Handle "default" cases by creating an empty string table entry.

I added these lines after observing that $sharedStrings was being indexed incorrectly with a test xlsx file. Adding these lines fixes that error.
@oleibman
Copy link
Collaborator

Can you provide a unit test that will demonstrate the issue, and prove that this fix works?

@oleibman
Copy link
Collaborator

No update in over a year. Closing.

@oleibman oleibman closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants