Fix division by zero warning #3312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Warning: Division by zero in /vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Calculation/Financial/CashFlow/Variable/Periodic.php on line 155
|
When we implement a bugfix, we always try to create a unit test to verify the original problem and confirm that the bugfix works as expected. Would you be able to create a unit test for this fix? |
MarkBaker
requested changes
Feb 4, 2023
| @@ -160,7 +160,8 @@ public static function presentValue($rate, ...$args) | |||
| for ($i = 1; $i <= $countArgs; ++$i) { | |||
| // Is it a numeric value? | |||
| if (is_numeric($aArgs[$i - 1])) { | |||
| $returnValue += $aArgs[$i - 1] / (1 + $rate) ** $i; | |||
| $val = (1 + $rate) ** $i; | |||
| $returnValue += $val != 0 ? $aArgs[$i - 1] / $val : 0; | |||
There was a problem hiding this comment.
$val will always be a float, so why do a loose types comparison here?
|
No update in over a year. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Warning: Division by zero in /vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Calculation/Financial/CashFlow/Variable/Periodic.php on line 155
This is:
Checklist: