Updates for latest SodiumCompat 1.x and allow for SodiumCompat 2.x #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sodium Compat has tagged new releases in the 1.x series, but has now also released a 2.0 version, which has a PHP 8.1 minimum. The GH Actions workflow for this package tests that the ruleset doesn't throw any errors on the polyfills repos themselves. So, to allow for both the 1.x as well as the 2.x branches, some changes to the workflows are required. This commit sorts this out by: * Adding extra builds to make sure that the SodiumCompat ruleset is tested against both Sodium Compat 1.x as well as 2.x. * Making sure that the tests against the 2.x branch sets the PHPCompatibility `testVersion` to `8.1-`. Refs: * https://github.com/paragonie/sodium_compat/releases * https://paragonie.com/blog/2024/04/release-sodium-compat-v2-and-future-our-polyfill-libraries
This is for a new class which was added to Sodium_Compat 1.x.
|
As the jobs/names of CI jobs have been updated, the branch protection needs an update too. I've just done this. Other open PRs will need a rebase once this PR has been merged. Also note: the CI failing against PHPCompatibility 10 is expected and not a concern until we're close to the PHPCompatibility 10 release. |
|
Note: as this PR adds an ignore for some code in the latest version of the 1.x SodiumCompat package, a new release is warranted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Actions: update the workflow to allow for Sodium Compat 2.x
Sodium Compat has tagged new releases in the 1.x series, but has now also released a 2.0 version, which has a PHP 8.1 minimum.
The GH Actions workflow for this package tests that the ruleset doesn't throw any errors on the polyfills repos themselves. So, to allow for both the 1.x as well as the 2.x branches, some changes to the workflows are required.
This commit sorts this out by:
testVersionto8.1-.Refs:
Sodium Compat ruleset: prevent triggering on the polyfill
This is for a new class which was added to Sodium_Compat 1.x.