Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: avoid writing a lock file #5

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Apr 23, 2024

When working with this repository as a developer, we should be using the latest compatible packages. By writing a lock file for Composer, we may get into a state where we are "stuck" on an older version of a dependency. This change avoids such a situation by telling Composer to not write out a lock file in the project.

@jrfnl
Copy link
Member

jrfnl commented Apr 24, 2024

Rebased without changes to get the build running (was disabled by GH due too low activity levels in the repo. I've manually re-enabled the workflow now)

@jrfnl jrfnl force-pushed the feature/composer.lock-false branch from 84a10bb to 6a4e456 Compare April 24, 2024 13:50
@jrfnl jrfnl added this to the Initial release milestone Apr 24, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredden !

@jrfnl jrfnl merged commit 2cdfa93 into PHPCompatibility:main Apr 24, 2024
5 checks passed
@fredden fredden deleted the feature/composer.lock-false branch April 24, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants