Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude {@internal} comments from description #15

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Exclude {@internal} comments from description #15

merged 2 commits into from
Mar 29, 2021

Conversation

afilina
Copy link
Collaborator

@afilina afilina commented Mar 29, 2021

Fixes #14

@afilina afilina requested a review from jrfnl March 29, 2021 21:15
jrfnl
jrfnl reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small questions and one reminder to open an issue for a follow-up. Other than that, looks good to me.

src/Parser/SniffParser.php Outdated Show resolved Hide resolved
@afilina afilina mentioned this pull request Mar 29, 2021
Open
@jrfnl jrfnl merged commit 511efee into main Mar 29, 2021
@jrfnl jrfnl deleted the exclude-internal branch March 29, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude @internal from docs
2 participants
@afilina @jrfnl