GH Actions: stop testing with PHP 8.4 against Composer < current #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer 1.x is no longer supported and while Composer 2.2 is an LTS version, the LTS is only for critical bugs and security issues, not necessarily for supporting new PHP versions. The LTS support was also officially only in effect until end of 2023 (and I have not seen any announcement of an extension). In practice, this means the following: * Composer 1.x and Composer 2.2. were previously made compatible with PHP 8.2 and 8.3 (released since the announcement). * However, it is unlikely that Composer 1.x and Composer 2.2 will be made compatible with PHP 8.4 and builds against those combinations are already failing. With the above in mind, I propose to stop running the tests against Composer 1.x/2.2 - PHP 8.4 combinations as they can only fail and those failures are not related to the plugin and outside our sphere of influence to fix. This commit updates the `integrationtest` workflow to put the above into effect. The `quicktest` workflow is currently not (yet) affected, but will be once PHP "latest" becomes PHP 8.4 towards the end of the year. At that time, a tweak will need to be made to the quicktest workflow as well. Ref: * composer/composer#10340
fredden
approved these changes
May 3, 2024
Potherca
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Composer 1.x is no longer supported and while Composer 2.2 is an LTS version, the LTS is only for critical bugs and security issues, not necessarily for supporting new PHP versions.
The LTS support was also officially only in effect until end of 2023 (and I have not seen any announcement of an extension).
In practice, this means the following:
With the above in mind, I propose to stop running the tests against Composer 1.x/2.2 - PHP 8.4 combinations as they can only fail and those failures are not related to the plugin and outside our sphere of influence to fix.
This commit updates the
integrationtestworkflow to put the above into effect.The
quicktestworkflow is currently not (yet) affected, but will be once PHP "latest" becomes PHP 8.4 towards the end of the year. At that time, a tweak will need to be made to the quicktest workflow as well.Ref: