-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "tested on" badge in README to include PHP v8.3 #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fredden for submitting this PR. Approving it for the content of the PR. Now 🤞🏻 to see if the upload to Coveralls works... ;-)
Sadly it looks like it's failed. :( https://github.com/PHPCSStandards/PHPCSUtils/actions/runs/6170710161/job/16747560218?pr=514 |
@fredden It has indeed. I've reported back to Coveralls with our test results. If you don't mind, I'm going to leave this PR open for the time being and may ask you to rebase once or twice after I make changes to the workflow to see if the changes have the desired effect. Will wait first for a response from the Coveralls team though. I suspect that removing the |
Still for testing purposes, I've removed the Coveralls token now (PR #515). I suspect if you rebase, the build will pass. (Note: I still won't merge the PR (yet), even when it does pass, as we may need to do more testing and having an open PR from a fork is useful for that) |
🎉 all (required) checks passed! |
@fredden Thanks for the rebase and happy to see it works! I've done some extensive testing with a Thanks for your help testing this! |
@fredden I've finally got the go-ahead from Coveralls, so shouldn't need this PR anymore for further testing. Could you rebase the PR to get passed the merge conflict ? I'll merge it after that. |
I've rebased this pull request. It looks like PHP 8.3 was already added to the list in duplicate in 64ee4ae |
Thanks for the rebase. Not sure what you mean by ?
You mean in the badge ? Yes, that's 100% true. I updated the badge as the build is no longer allowed to fail. Sorry, I forgot that was included in this PR too. The badge ordering though was not yet done, so this PR should still be a valid change. |
While this change is hopefully useful, the primary purpose of this pull request is to test if the recent changes to the Coveralls workflow work well with an external contributor or not.