BCTokens: test arrays against PHPCS upstream #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for all backfilled token arrays in the `BCTokens` class to verify whether they are still in line with the upstream version. These tests should be considered _risky_ as they can fail without warning if something upstream would change. These tests would also fail when run against older PHPCS versions for those token array which havehad changes over time. For that reason, they have been placed in a separate test group `compareWithPHPCS`, which is excluded from being run by default. In the Travis script two additional runs have been added to specifically and only run these tests against PHPCS `master` and `4.x`. Both of these builds have been added to the `allow_failures` array. Loosely related to 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for all backfilled token arrays in the
BCTokensclass to verify whether they are still in line with the upstream version.These tests should be considered risky as they can fail without warning if something upstream would change.
These tests would also fail when run against older PHPCS versions for those token array which have had changes over time.
For that reason, they have been placed in a separate test group
compareWithPHPCS, which is excluded from being run by default.In the Travis script two additional runs have been added to specifically and only run these tests against PHPCS
masterand4.x. Both of these builds have been added to theallow_failuresarray.Loosely related to #5