Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for utils being up-to-date with PHPCS itself #5

Open
jrfnl opened this issue Nov 18, 2019 · 0 comments
Open

Add tests for utils being up-to-date with PHPCS itself #5

jrfnl opened this issue Nov 18, 2019 · 0 comments
Labels
Type: chores/QA

Comments

@jrfnl
Copy link
Member

jrfnl commented Nov 18, 2019

Add a test suite/ separate test group which will only be run against PHPCS dev-master and for which the build is allowed to fail.

The tests which should be run there are:

  • Run the PHPCS native utility functions against the unit tests of PHPCSUtils\BackCompat\BCFile and make sure they pass.
  • Run the PHPCSUtils\BackCompat\BCFile versions of the utility methods against the unit tests for the same of PHPCS itself.

This should:

  • Alert when the PHPCS native functions have changed and the PHPCSUtils counterparts have not been updated for this yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: chores/QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrfnl