Skip to content

Commit

Permalink
GH Actions/coverage: remove COVERALLS_TOKEN
Browse files Browse the repository at this point in the history
... to test (confirm) that uploading the coverage results will then work (again) for PRs from outside contributors (forks).

Note: I'm explicitly **_not_** setting the `github-token` to `${{ secrets.GITHUB_TOKEN }}` as the action runner _should_ have access to that token anyhow.
Not setting the input should confirm that. If that doesn't work, the GH token can still be added at a later point.
  • Loading branch information
jrfnl committed Sep 13, 2023
1 parent d79fda8 commit dac4d7f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ jobs:
if: ${{ success() }}
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.COVERALLS_TOKEN }}
format: clover
file: build/logs/clover.xml
flag-name: php-${{ matrix.php }}-phpcs-${{ matrix.phpcs_version }}
Expand All @@ -369,5 +368,4 @@ jobs:
- name: Coveralls Finished
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.COVERALLS_TOKEN }}
parallel-finished: true

0 comments on commit dac4d7f

Please sign in to comment.