Refactor TileMap serialization #1012

DanRStevens · 2021-06-26T21:20:03Z

Reference: #830

Refactor TileMap serialization code to be less directly dependent on XML code.

Removes using namespace for the XML code.

Restrict attribute scope to following loops.

The iterators being used here will ensure that only XmlElement nodes are iterated over.

DanRStevens added 14 commits June 26, 2021 14:31

Use dictionaryToAttributes in serializeTile

98d2fc3

Return generated XmlElement from serializeTile

80e7f67

Combine if condition to avoid duplicated code

bf80bb9

Regroup if condition to reduce repetition

10d1df1

Use dictionaryToAttributes to serialize view parameters

220b479

Use range-for loop for mine locations

e57e5c9

Use dictionaryToAttributes to write mine location

d3ebfcd

Use attributesToDictionary to load view parameters

7440d14

Restrict attribute scope to following loops.

Remove useless calls to toElement()

bcad55b

The iterators being used here will ensure that only XmlElement nodes are iterated over.

Use attributesToDictionary to read mine locations

5261bfc

Use attributesToDictionary to read tile data

60749b7

Add namespace prefix to NAS2D::Xml::XmlElement

d58b344

Use auto to catch created XmlElement

ae6e99c

Remove using namespace NAS2D::Xml;

a01ad46

DanRStevens merged commit d56f330 into master Jun 26, 2021

DanRStevens deleted the refactorTileMapSerialize branch June 26, 2021 21:24

Provide feedback