Refactor robot id string serialization #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the function is only meant to work on RobotCommand structures, then that's what it should accept. It would be unsafe to call it with any other type of Structure.
The nullptr check fits more logically with the other similar check outside of `readRccRobots`. Besides, this method doesn't even really need to know about XmlAttributes.
When reading a specific attribute and getting back a string, a default value of "" is used if the attribute isn't found. That is a safe value that effectively does nothing in `readRccRobots`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #830
Refactor robot id list processing for
RobotCommandstructures. Lift XML related code out of lower level functions. Use a more functional programming style for array transformations.