added underscore smybol in PRODUCT_BUNDLE_IDENTIFIER regex matching #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OutdatedGuy
reviewed
Nov 19, 2023
OutdatedGuy
requested changes
Nov 19, 2023
|
@OutdatedGuy I think @imranspahic misleading what I raised on the issue. We didn't know the functionality of this double quote |
|
@chandrabezzo, this PR was opened prior to your issue and is for a different issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating project it can be named with underscore: example_project.
Package was not renaming
PRODUCT_BUNDLE_IDENTIFIERfor the following format: com.example.example_project.This PR adds missing symbol in regex to correctly modify all occurrences of
PRODUCT_BUNDLE_IDENTIFIER