Update OrchardCore.OpenId to explicitly reference Microsoft.IdentityModel.Protocols.OpenIdConnect #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odel.Protocols.OpenIdConnect
kevinchalet
added
OpenId
dependencies
Piedone
requested changes
May 14, 2024
…nect is explicitly listed in Dependencies.props
Piedone
approved these changes
May 15, 2024
|
Thanks for the review, @Piedone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenID module uses both the MSFT OIDC handler and OpenIddict and both projects depend on IdentityModel. Unfortunately, while OpenIddict references a recent version (7.5.1), the MSFT OIDC handler package still references an old version (7.1.2):
Unfortunately, having mismatched versions of the
System.IdentityModel.*orMicrosoft.IdentityModel.*packages is explicitly NOT supported by the Wilson team has recently caused a lot of pain due to very-hard-to-find bugs:This PR fixes that by explicitly referencing
Microsoft.IdentityModel.Protocols.OpenIdConnectto ensure it uses the same IdentityModel version as OpenIddict:(I strongly recommend including this change in 2.0, hence the explicit
2.0milestone 🤣)