Skip to content

Commit

Permalink
display "<" and ">" correctly in comments and conllu preview
Browse files Browse the repository at this point in the history
  • Loading branch information
Johannes Heinecke committed Dec 21, 2024
1 parent 27e0f55 commit 6e9ec27
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changes

## Version 2.29.2
* corrected bug: "<" and ">" in comments are now correctly displayed

## Version 2.29.1
* Fatal error if gui/ does not contain necessary html, css, js files and jquery libraries
* test modified
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM openjdk:17-alpine

ARG VERSION=2.29.0
# docker build --build-arg VERSION=2.29.0 -t jheinecke/conllueditor:2.29.0 .
# docker build --build-arg VERSION=2.29.0 -t jheinecke/conllueditor:latest .
ARG VERSION=2.29.2
# docker build --build-arg VERSION=2.29.2 -t jheinecke/conllueditor:2.29.2 .
# docker build --build-arg VERSION=2.29.2 -t jheinecke/conllueditor:latest .
# docker run -t --rm --name conllueditor -p 5555:5555 --user 1000:1000 -v </absolute/path/to/datadir>:/data --env filename=tt.conllu jheinecke/conllueditor:latest
# docker push jheinecke/conllueditor:2.29.0
# docker push jheinecke/conllueditor:2.29.2
# docker push jheinecke/conllueditor:latest

# docker exec -it conllueditor /bin/sh
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The editor provides the following functionalities:
* finding similar or identical sentence in a list of CoNLL-U files, see section [Find Similar Sentences](#find-similar-sentences)
* configuring the UI on order to hide unneeded functionalities which otherwise clutter the UI

Current version: 2.29.1 (see [change history](CHANGES.md))
Current version: 2.29.2 (see [change history](CHANGES.md))

ConlluEditor can also be used as front-end to display the results of dependency parsing in the same way as the editor.
* dependency tree/dependency hedge
Expand Down
7 changes: 4 additions & 3 deletions gui/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
@author Johannes Heinecke
@version 2.29.0 as of 3rd November 2024
@version 2.29.2 as of 21st December 2024
*/


Expand Down Expand Up @@ -152,7 +152,7 @@ function getRaw(what, title) {
//$('#rawtext').empty();
//$('#showRawModalLabel').html(what);
//console.log("DD " + JSON.stringify(data));
$('#rawtext').append(data.raw);
$('#rawtext').append(data.raw.replaceAll("<", "&lt;").replaceAll(">", "&gt;"));
}
});
}
Expand Down Expand Up @@ -1913,7 +1913,8 @@ function formatPhrase(item) {


// display comments
$("#commentfield").append(item.comments)
var cc = item.comments.replaceAll("<", "&lt;").replaceAll(">", "&gt;");
$("#commentfield").append(cc);

// install svg download button
downloadSVG("a2");
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
author Johannes Heinecke
version 2.29.1 as of 9th November 2024
version 2.29.2 as of 21st December 2024
-->

<modelVersion>4.0.0</modelVersion>
<groupId>com.orange.labs</groupId>
<artifactId>ConlluEditor</artifactId>
<version>2.29.1</version>
<version>2.29.2</version>
<packaging>jar</packaging>

<properties>
Expand Down

0 comments on commit 6e9ec27

Please sign in to comment.