Introduce globbing for the JSONS input #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented globbing resolution based on @actions/glob [1]. Added test to validate globs are being read. Fixes OrRosenblatt#19. 1: https://github.com/actions/toolkit/tree/main/packages/glob
|
Okay, I see some issues with this. Using it as a github action like so: - name: Validate JSON
uses: kiriakos/validate-json-action@e97bf4885314574701657ab73e5b7fceb3e07130
with:
schema: .github/schemas/donations-schema.json
env:
INPUT_SCHEMA: .github/schemas/donations-schema.json
INPUT_JSONS: "/home/runner/work/Donations/Donations/*/donations.json"
#OR
INPUT_JSONS: "/*/donations.json"
#OR
INPUT_JSONS: "*/donations.json"
#etc..Does not work because the action adds the |
Hans5958
pushed a commit
to Hans5958/validate-json-action
that referenced
this pull request
Jan 18, 2023
…and_yarn/types/node-18.7.18 Bump @types/node from 18.7.16 to 18.7.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented globbing resolution based on @actions/glob [1].
Added test to validate globs are being read.
Fixes #19.
1: https://github.com/actions/toolkit/tree/main/packages/glob