Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portugueses Translation. #894

Open
wants to merge 2 commits into
base: v3-main
Choose a base branch
from

Conversation

MardSilva
Copy link

Hi!
I've added the translation file for (Brazilian Portuguese). Well, i've tried to add on the 'Dictionaries' folder, but, didn't solved. Only the Core folder had the Brazilian dictionary file (.dic). Just add on the other projects and folders who has the translation to work on Portiguese.

@alexandre-mbm
Copy link
Contributor

Olá! Como falante do mesmo idioma, eu gostaria de entender melhor o que está se passando.

@MardSilva MardSilva changed the title Brazilian Portugueses Tranlation. Brazilian Portugueses Translation. Apr 24, 2023
@kmcnaught
Copy link
Collaborator

@MardSilva Thanks for the contribution, I've fixed this up. The translations file only needs to be in Core but it needed adding as a EmbeddedResource and copying to the build directory. I've also hooked up a few more things.

The only issue now is that the dictionary file you are using is enormous compared to what we normally use and there's a significant performance hit when loading the file. We normally aim for 75k-100k words in size. Here are Julius' original guidelines:

i)It should be roughly 75k-100k words in size (it can be a bit less or more, but there is a performance overhead for huge dictionaries so there is no point choosing one that is 1 million words long).
ii)No entries of 1 character as the user can type these from the keyboard and they will be ignored.
iii)All words should be lower case, unless the case has actual meaning, e.g. proper nouns like names, abbreviations like "ATM", or some other meaningful use of capital letters. OptiKey will case words automatically otherwise.
iv)There is no need to manually inspect the whole word list, but sanity check it for mistakes, swear words and colloquialisms that wouldn't be used by the average person. It also doesn't need to contain obscure words. Generally speaking it should cover a normal vocabulary for an adult speaker.
v)If your dictionary includes ligatures (e.g. "œ" and "æ") then please convert them into the individual letters (e.g. "oe" and "ae"). If you think this is not appropriate please contact me to discuss options.
vi)The dictionary files have to be encoded in unicode (UTF-8). If you encode them in ASCII some characters (e.g. ü) will instead be displayed as the 'replacement character' (�). To do this just copy/paste the whole word list into Notepad and save the file with the Encoding set to "UTF-8"

Can you please try to find a more suitable word list?

@kmcnaught
Copy link
Collaborator

The dictionary here has 260k words which is closer to what we want: WinEdt Unicode Dictionaries

But a smaller one would be better if possible please

- Hook up some more things
- Add to languages keyboard
- Move and rename some things to be consistent with existing conventions
- Fix where/how the dictionary file is included
@kmcnaught
Copy link
Collaborator

(force pushed tiny change after renaming file but not updating in csproj)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants