Add Keyboard Editor to Management Console #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add KeyPopup feature Make inheritable types of KeyCommands
Major revision of Keyboard designer. Major revision of XmlKeyboard and DynamicKeyboard
Tidy up code for upgrade to new XmlKeyboard model Minor changes to LayoutViewModel
…ic keyboards can override properly.
Add XmlDefinition for a Switch KeyCommand
Fixes some theme overides
|
@AdamRoden We are starting to work on a potential pre-release. Do you consider this PR ready for testing? |
|
@JuliusSweetland The PR is ready to test. |
|
Great thanks. I have to prepare a pre release without this pr first to be
able to test and stabilise that work, but this will be integrated after
that. Have a good weekend.
…On Fri, 6 Jan 2023, 17:55 AdamRoden, ***@***.***> wrote:
@JuliusSweetland <https://github.com/JuliusSweetland> The PR is ready to
test.
—
Reply to this email directly, view it on GitHub
<#871 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEA7AKMTCSKD736QPEEYXLWRBMBLANCNFSM6AAAAAARCQJEQ4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took an overhaul of dynamic keyboards and the migration of various pieces of code to different classes in order for this to be built properly.
We should get many stakeholders to beta test this one to ensure their versions of keyboard files get interpreted as expected. I'm happy to test any keyboards shared with me if people submit them.
Let the review begin.