Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add ability to clear staging slots directly #16930

Merged

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Nov 21, 2024

Overview

This PR adds the ability to clear staging area slots directly by interacting with a column 4 slot.

In order to preserve the functionality where pressing "done" does NOT delete labware in a slot of the labware is the same labware when users opened the toolbox, i added a parameter to the handleClear function to conditionally clear existing labware.

closes RQA-3626

Test Plan and Hands on Testing

Mess around with the deck setup tools. Add staging areas, add adapters, labware, modules, etc. Clear the slot both from the toolbox and the slot overflow menu. Just generally try to break it.

Changelog

  • add ability to clear staging slots directly

Review requests

See test plan

Risk assessment

Low

@shlokamin shlokamin requested review from a team as code owners November 21, 2024 17:22
@shlokamin shlokamin requested review from TamarZanzouri, koji, ncdiehl11, alexjoel42 and jerader and removed request for a team and TamarZanzouri November 21, 2024 17:22
@jerader
Copy link
Collaborator

jerader commented Nov 21, 2024

if you zoom into the 3rd column staging area and press "clear", it incorrectly zooms out. we want it to stay zoomed in since the slot turns into a standard slot

Screen.Recording.2024-11-21.at.13.05.20.mov

@jerader
Copy link
Collaborator

jerader commented Nov 21, 2024

Also, labware in 4th column slot is incorrectly deleted

Screen.Recording.2024-11-21.at.13.06.55.mov

@shlokamin
Copy link
Member Author

uh oh thanks @jerader ill fix

@shlokamin
Copy link
Member Author

@jerader i think the second issue is not a regression, it's in edge currently. but i think i fixed it and this is desired behavior now?

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing this! did a bunch of smoke testing and looks good to me

@shlokamin shlokamin merged commit d5b7e61 into edge Nov 22, 2024
36 checks passed
@shlokamin shlokamin deleted the protocol-designer_add-ability-to-clear-staging-slots-directly branch November 22, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants