-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): RobotContext: Add gripper commands #16752
Open
Laura-Danielle
wants to merge
39
commits into
edge
Choose a base branch
from
PLAT-353-PLAT-354-add-gripper-commands
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
changed the base branch from
edge
to
PLAT-453-PLAT-454-add-pipette-support-functions
November 13, 2024 17:49
sfoster1
changed the title
feat(robot_context): Add gripper commands
feat(api): RobotContext: Add gripper commands
Nov 13, 2024
sfoster1
changed the base branch from
PLAT-453-PLAT-454-add-pipette-support-functions
to
edge
November 13, 2024 17:50
@Laura-Danielle Can you rebase this on top of the pipette one and target it there or something? It's really hard to see what changed in just this PR vs that one. |
Laura-Danielle
force-pushed
the
PLAT-353-PLAT-354-add-gripper-commands
branch
from
November 21, 2024 14:49
563be9b
to
736370a
Compare
sfoster1
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty happy with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding
RobotContext
gripper commands.Test Plan and Hands on Testing
Check that the gripper can open and close using the robot context commands.
Changelog
Review requests
Check that the paths make sense
Risk assessment
Low. Unrelease protocol API.