build: bump Stylus SDK to v0.7.0-beta.1 and alloy to v0.8.13 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e539ee9)
(cherry picked from commit 0cab5f9)
(cherry picked from commit e840848)
(cherry picked from commit 431b706)
(cherry picked from commit f921f1b)
(cherry picked from commit 91a0e8e)
(cherry picked from commit 25d400c)
(cherry picked from commit 0596f0c)
(cherry picked from commit 65a0c6e)
|
Blocked by OpenZeppelin/koba#14 |
✅ Deploy Preview for contracts-stylus canceled.
|
3 tasks
|
Unexpected change in |
Open
qalisander
reviewed
Dec 6, 2024
| @@ -30,36 +33,11 @@ pub type Wallet = FillProvider< | |||
| Ethereum, | |||
| >; | |||
|
|
|||
| /// Convenience type alias that represents an alloy provider. | |||
| pub type Provider = FillProvider< | |||
There was a problem hiding this comment.
@bidzyyys I haven't found any place where this Provider was used. Just dropped it
qalisander
reviewed
Dec 6, 2024
| /// | ||
| /// May panic if unable to load the `RPC_URL` environment variable. | ||
| #[must_use] | ||
| pub fn provider() -> Provider { |
There was a problem hiding this comment.
And this function also wasn't used
qalisander
reviewed
Dec 6, 2024
Cargo.toml
Outdated
| @@ -136,3 +136,12 @@ incremental = false | |||
|
|
|||
| [profile.dev] | |||
| panic = "abort" | |||
|
|
|||
| # TODO#q: remove this once the fix is released | |||
There was a problem hiding this comment.
Remove this patch after stylus-sdk release
|
@qalisander sth went wrong with your changes, see last E2E tests errors. |
|
I see. But those errors are related to |
3 tasks
…eta.1 # Conflicts: # examples/erc1155/src/constructor.sol
…eta.1 # Conflicts: # contracts/src/token/erc20/extensions/permit.rs # contracts/src/utils/math/storage.rs # lib/e2e/src/lib.rs
0xNeshi
reviewed
Dec 10, 2024
| @@ -179,6 +177,61 @@ impl MethodError for Error { | |||
| } | |||
| } | |||
|
|
|||
| sol_interface! { | |||
There was a problem hiding this comment.
Moved it back into the main file after all :D
…eta.1 # Conflicts: # Cargo.toml # contracts/src/utils/math/storage.rs
…eta.1 # Conflicts: # contracts/src/access/control.rs # contracts/src/finance/vesting_wallet.rs # contracts/src/token/erc1155/mod.rs # contracts/src/token/erc1155/receiver.rs # contracts/src/token/erc20/extensions/capped.rs # contracts/src/token/erc20/extensions/metadata.rs # contracts/src/token/erc721/extensions/enumerable.rs # contracts/src/token/erc721/mod.rs # contracts/src/utils/metadata.rs # contracts/src/utils/pausable.rs
…eta.1 # Conflicts: # Cargo.lock # contracts/src/finance/vesting_wallet.rs # contracts/src/token/erc1155/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #424
PR Checklist