-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a governor extension that implements a security council #5303
base: master
Are you sure you want to change the base?
Conversation
|
// if there is no council | ||
// ... only the proposer can cancel | ||
// ... no restriction on when the proposer can cancel | ||
uint256 proposalId = hashProposal(targets, values, calldatas, descriptionHash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do when #5290 is merged:
uint256 proposalId = hashProposal(targets, values, calldatas, descriptionHash); | |
uint256 proposalId = getProposalId(targets, values, calldatas, descriptionHash); |
Looks good other than some comments. Would it make sense to call it something like |
Compound Governance already has a feature like this where the council is called the |
Fixes #5301
PR Checklist
npx changeset add
)