Cxx17 updates #58
Merged
Cxx17 updates #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Morley <[email protected]>
Signed-off-by: Jon Morley <[email protected]>
|
@meshula Should please double check it is ok to update this without supporting the json schema_version_map. |
Signed-off-by: Jon Morley <[email protected]>
rogergodspeed
force-pushed
the
cxx17_updates
branch
2 times, most recently
from
23c0513
to
6477e25
Compare
Signed-off-by: Jon Morley <[email protected]>
Signed-off-by: Jon Morley <[email protected]>
|
@rogergodspeed It's fine to defer that until everything else is working.... |
meshula
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Can you make a note in the README.md about the work remaining? Specifically the version map support. I'm happy to land this, with a breadcrumb about the outstanding work remaining so that no one is surprised. I don't think anyone is dependent on managing the versioning system from C at the moment, so deferring it is OK.
Signed-off-by: Jon Morley <[email protected]>
meshula
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the c++17 branch changes to OpenTimelineIO. Specifically replacing the custom any class with std::any and optional with std::optional.
NOTE: The json version schema feature has NOT been ported and instead the new schema_version_map has been hardcoded to an empty map.