Switch to 16bpp display mode to support GOG.com version 1.0 hotfix2 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
changed the title
|
Yea, that worked. The game works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our display mode to 16bpp.
Although I remember using specifically 24bpp as it's easier to debug issues (as there are only 24bpp framebuffers, but no 24bpp textures).
The reason why this is necessary is explained in #142 (comment).
I'm not too happy about this change, as it's already the second patch in OpenSWE1R for the GOG.com version, which shouldn't have to exist in the first place. At this point, the GOG.com version support in OpenSWE1R mostly consists of workarounds for their "dirty" patches.
I've already upstreamed this issue to the GOG.com support, although the damage has already been done.
A proper fix for this in OpenSWE1R would be #152. Until then, this 16bpp mode must be kept.
Closes #151