Skip to content

Commit

Permalink
Remove bower components folder
Browse files Browse the repository at this point in the history
Instead of including the components in the repo we now
use the built in package manager that comes with bower`
to manage and version lock deps.

This introduces another step in getting started, which
is to run bower install.
  • Loading branch information
samccone authored and BrianAdams committed Jun 3, 2014
1 parent 8272799 commit d3bc1a6
Show file tree
Hide file tree
Showing 14 changed files with 7 additions and 2,095 deletions.
1 change: 1 addition & 0 deletions src/static/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bower_components
6 changes: 6 additions & 0 deletions src/static/bower.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "static openrov",
"dependencies": {
"fpsmeter": "~0.3.1"
}
}
30 changes: 0 additions & 30 deletions src/static/bower_components/fpsmeter/.bower.json

This file was deleted.

9 changes: 0 additions & 9 deletions src/static/bower_components/fpsmeter/.editorconfig

This file was deleted.

51 changes: 0 additions & 51 deletions src/static/bower_components/fpsmeter/.jshintrc

This file was deleted.

33 changes: 0 additions & 33 deletions src/static/bower_components/fpsmeter/CONTRIBUTING.md

This file was deleted.

116 changes: 0 additions & 116 deletions src/static/bower_components/fpsmeter/Gruntfile.js

This file was deleted.

50 changes: 0 additions & 50 deletions src/static/bower_components/fpsmeter/README.md

This file was deleted.

20 changes: 0 additions & 20 deletions src/static/bower_components/fpsmeter/component.json

This file was deleted.

Loading

3 comments on commit d3bc1a6

@codewithpassion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good people!
If you do things like this, you have to change the image building process too!
Because a manual install of the OpenROV Cockpit is not what 90% of the ROV users do IMHO.

@BrianAdams
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well right now, most people are probably burning the image. So the image should probably go ahead and get all of the referenced components. We should update our install docs and be clear in what we support.

@codewithpassion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian, yes, that's what I'm saying. But if anybody introduces changes like this, we have to DO the change in the image process.

Please sign in to comment.