Optionally align the top toolbar buttons horizontally centred #21989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronVanGeffen
force-pushed
the
toolbar-alignment
branch
from
4277e1a
to
0696ea0
Compare
AaronVanGeffen
changed the title
AaronVanGeffen
force-pushed
the
toolbar-alignment
branch
from
0696ea0
to
fbbc125
Compare
Gymnasiast
reviewed
May 10, 2024
AaronVanGeffen
force-pushed
the
toolbar-alignment
branch
2 times, most recently
from
776fa4c
to
96ce7f7
Compare
Gymnasiast
approved these changes
May 10, 2024
23 tasks
| { | ||
| screenCoords.y = kTopToolbarHeight + 3; | ||
| } | ||
|
|
||
| DrawText(dpi, screenCoords, { COLOUR_WHITE }, buffer); | ||
|
|
||
| // Make area dirty so the text doesn't get drawn over the last |
There was a problem hiding this comment.
L143 needs to be updated to take into account the new variable y location of the fps counter. Causes #22066
There was a problem hiding this comment.
Oops. This is a bit surprising though, as it uses the same screenCoords variable we modify up ahead. Will look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #622 / #15643 as an optional alternative toolbar mode.
std::ranges::reverse_viewyet?For a follow-up PR, we could look into moving the bottom panels to the top as well, or indeed moving the buttons to the bottom. I'd prefer not to move the goal posts for this PR too much.
Setting on:
Setting off:
