New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce preloader scene with progress info #21893
Introduce preloader scene with progress info #21893
Conversation
Co-authored-by: ζeh Matt <[email protected]>
Reset screen to a nice background colour
This splits off the initialisation calls to a new InitialiseRepositories function. The SetCompletionScene invocation is moved to the Launch method. When the game is running in headless mode, the preloader is not used. Instead, InitialiseRepositories is called in-thread, and the transition to the 'completion scene' happens immediately after.
e1d0e06
to
803f292
Compare
Add strings for checking and loading title sequence
548c4c8
to
ab7808a
Compare
With the latest changes in, I believe this is now ready for review. NB: I have added delays to loading the object and scenario repositories (80bd69a). These should obviously be removed before merging. |
Progress is passed on to PreloaderScene and NetworkInfo window from there.
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for testing!
That would be due to deliberate delays added to loading the object and scenario repositories (80bd69a).
Thanks for reporting this. That shouldn't happen, of course. Rendering seems to (not) be happening during the object indexing process, for some reason. I can't reproduce it on macOS, but I can reproduce it on my Linux box.
Yes, this is the right way to go about it, indeed. |
ea3c016
to
ab9c525
Compare
Thanks, that's a lot better! Loading times now look similar. 😄
2024-05-06.20-54-36.mp4 |
As we've discussed on Discord in the mean time, this is a side-effect of using OpenGL. Unfortunately, with the current set-up, we cannot force OpenGL to do a redraw. This is possible for the software renderer, though. This means the progress info will be more up-to-date when using the software renderer.
This isn't a trivial change, unfortunately. However, I have pushed some commits with a bodge that I hope will make this possible, still. If this bodge works, I'd like to clean it up a little, though 😅 |
Plugins seem to have some issues in the newest version in the loader scene, but do seem to load properly in the end when opening a park. 2024-05-06.22-51-31.mp4 |
Thanks for testing, @Basssiiie. As I thought, loading them through the preloader will be more difficult. I think it would be better to leave them as they were for now, and add them to the preloader in a follow-up PR. I'll revert the changes related to plugins tomorrow. |
80c04a0
to
974794b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only ask is for a comment to GetPreloaderScene
, then it's good
974794b
to
f51404d
Compare
Small oversight from #21893.
Small oversight from #21893.
Following up from #21888, this adapts the loading scene from #10180, calling it the
PreloaderScene
instead. This scene is used to display loading messages before the title scene is loaded. For example, when the object index is being built. It should not be merged before #21888, so marking this as a draft.In its current form, it uses the NetworkStatus window to display status messages. I'd like to replace this with a dedicated ProgressBar window, using these same status messages as the window caption.
I'd like this progress bar window to look something like OpenLoco/OpenLoco#2411, with an OpenRCT2 twist. For example, use a roller coaster track to indicate progress. This progress bar window could then be used in-game as well, for example when loading and saving games. (Though not autosaves, ideally.)
Screen.Recording.2024-05-06.at.16.57.30.mp4
To do in this PR:
To do in a follow-up PR: