Replace constant notation in Window.h #21796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Hopkinson
commented
Apr 14, 2024
| @@ -43,14 +43,14 @@ enum class CloseWindowModifier : uint8_t; | |||
| constexpr uint8_t CloseButtonWidth = 10; | |||
|
|
|||
| #define SCROLLABLE_ROW_HEIGHT 12 | |||
There was a problem hiding this comment.
I left this untouched as it is being changed in this PR #21760
Harry-Hopkinson
force-pushed
the
refactor-constants-Window.h
branch
from
6a89f50
to
cd9ca1d
Compare
Gymnasiast
approved these changes
Apr 16, 2024
ZehMatt
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #21432, replace constant notation in Window.h