Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add hot reloading capability using file watchers #8987

Closed
wants to merge 1 commit into from

Conversation

itstauq
Copy link
Member

@itstauq itstauq commented Jun 27, 2024

Description

An alternative approach to #8971 and #8988

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@itstauq itstauq changed the title [WIP] Add manual hot reloading capability in syft.node.server:serve_node [WIP] Add hot reloading capability using file watchers Jun 27, 2024
Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to complete the testing of this completely but it would be great if this works too.

As an aside, we might have to add watchdog as a dependency to Syft, I had to locally install it to continue.

@itstauq
Copy link
Member Author

itstauq commented Jun 30, 2024

Closing in favour of #8988

@itstauq itstauq closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants