Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migrations for Enclave Changes to UserCode and CodeHistory #8986

Conversation

BrendanSchell
Copy link
Contributor

Description

Add migrations for UserCode and CodeHistory for enclave changes. Includes upgrades to UserCode and SubmitUserCode to add deployment policies. Will have to be updated based on naming changes to deployment policies in #8981 so PR is WIP for now.

Closes

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Tested locally by retrieving and converting using obj.migrate_to(version_no) to ensure no errors.

Checklist

Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff Brendan!

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shubham3121 shubham3121 force-pushed the bschell/update-migrations-for-enclave-pr branch from f733a03 to 242c4a0 Compare July 2, 2024 07:33
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Made changes to UserCode.

@shubham3121 shubham3121 changed the title [WIP] Add Migrations for Enclave Changes to UserCode and CodeHistory Add Migrations for Enclave Changes to UserCode and CodeHistory Jul 2, 2024
@shubham3121 shubham3121 force-pushed the bschell/update-migrations-for-enclave-pr branch from 6d75878 to 242c4a0 Compare July 2, 2024 07:59
@shubham3121 shubham3121 changed the base branch from tauquir/enclave-prototype to dev July 2, 2024 07:59
@shubham3121 shubham3121 changed the base branch from dev to tauquir/enclave-prototype July 2, 2024 08:05
@shubham3121 shubham3121 merged commit a3b5de3 into tauquir/enclave-prototype Jul 2, 2024
3 of 4 checks passed
@shubham3121 shubham3121 deleted the bschell/update-migrations-for-enclave-pr branch July 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants