Add migrations for latest UserCode and CodeHistory #8985
Conversation
| @@ -1933,3 +1933,15 @@ def migrate_usercode_v5_to_v4() -> list[Callable]: | |||
| drop("origin_node_side_type"), | |||
| drop("l0_deny_reason"), | |||
| ] | |||
|
|
|||
|
|
|||
| @migrate(UserCodeV5, UserCode) | |||
There was a problem hiding this comment.
NIT: could we delete UserCodeV4 from the codebase?
There was a problem hiding this comment.
and also its corresponding migrations.
There was a problem hiding this comment.
as since we need to maintain migrations for only last two versions.
There was a problem hiding this comment.
ya I can, but it kind of seems like bad practice in a way to lose the ability to migrate from old versions. Especially since all of these updates to UserCode are within such a short timeframe (V4 was just two weeks ago), migrations would be broken from UserCode from less than a month ago with this approach. Going to raise in slack since I think it would be good to understand why we do it this way.
| @@ -1933,3 +1933,15 @@ def migrate_usercode_v5_to_v4() -> list[Callable]: | |||
| drop("origin_node_side_type"), | |||
There was a problem hiding this comment.
Can we also add migrations for SubmitUserCode ?
There was a problem hiding this comment.
ya I can. I didn't see any migrate decorators in the codebase for any client-side code so that's why I wasn't sure, but it looks like we call migrations on all args and kwargs so I'll add.
- restage protocol
shubham3121
deleted the
bschell/add-migrations-for-old-enclave-code-removal
branch
Description
Adds missing migrations from #8969 for UserCode and CodeHistory.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Tested locally using
obj.migrate_to(version_no).Checklist