Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syft function result repr #8984

Merged
merged 5 commits into from
Jul 8, 2024
Merged

fix syft function result repr #8984

merged 5 commits into from
Jul 8, 2024

Conversation

abyesilyurt
Copy link
Contributor

@abyesilyurt abyesilyurt commented Jun 27, 2024

has_result_read_permission was incorrectly set in the code.call endpoint, leading it to return result.as_empty() instead of the actual result. Consequently, the output appeared as None.

Closes https://github.com/OpenMined/Heartbeat/issues/1427

before
Screenshot 2024-07-08 at 07 32 38

after
Screenshot 2024-07-08 at 07 32 55

@abyesilyurt abyesilyurt changed the title fix ActionObject caching wip fix ActionObject caching Jul 2, 2024
@abyesilyurt abyesilyurt changed the title wip fix ActionObject caching fix syft function result repr Jul 8, 2024
@abyesilyurt abyesilyurt merged commit 87750de into dev Jul 8, 2024
26 checks passed
@abyesilyurt abyesilyurt deleted the aziz/action_cache branch July 8, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants