Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show requesting domain (for DistributedProject as well as base Requests) #8983

Conversation

snwagh
Copy link
Contributor

@snwagh snwagh commented Jun 27, 2024

This changes the output to show the domain name at which the request was made. Tagging for PM review since I change the base object Request's repr. The output looks as follows (Requested on added):

Screenshot 2024-06-27 at 10 51 39 AM

The implementation may not be optimal since I am making the API call (I can take a look at the relation between _coll_repr_ and _repr_html_ to see if I can do this efficiently if that is promising).

Copy link
Member

@itstauq itstauq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@itstauq itstauq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: On a closer look, I was wondering if we could directly patch the Request objects in DistributedProject.requests property? Otherwise merging this will change the Request object for existing single projects as well.

@snwagh
Copy link
Contributor Author

snwagh commented Jun 27, 2024

@itstauq Since the DistributedProjects uses the same objects inside it, I was wondering if this is a better fix as long as we run it by PM. It changes the Request object for the single projects too but it's just a change to the repr so not a conflicting change IMO.

@snwagh
Copy link
Contributor Author

snwagh commented Jun 28, 2024

@itstauq To address your comment, added another commit that does not create a breaking change.

@madhavajay madhavajay added this to the 24Q3 - G2M1 Enclave Python milestone Jul 1, 2024
@madhavajay
Copy link
Collaborator

Closing for now, we will move the domain information to Project code in this PR: #8999

@madhavajay madhavajay closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants