Show requesting domain (for DistributedProject as well as base Requests) #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itstauq
requested changes
Jun 27, 2024
|
@itstauq Since the DistributedProjects uses the same objects inside it, I was wondering if this is a better fix as long as we run it by PM. It changes the Request object for the single projects too but it's just a change to the repr so not a conflicting change IMO. |
|
@itstauq To address your comment, added another commit that does not create a breaking change. |
|
Closing for now, we will move the domain information to Project code in this PR: #8999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the output to show the domain name at which the request was made. Tagging for PM review since I change the base object
Request's repr. The output looks as follows (Requested on added):The implementation may not be optimal since I am making the API call (I can take a look at the relation between
_coll_repr_and_repr_html_to see if I can do this efficiently if that is promising).