Add linter and error for code submissions that use global scope variables / methods #8974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add test for when the submit code contains `global`
…re submitting code
khoaguin
changed the title
- add a catch for syntax error when parsing the submitted code
…heck function - add some type annotations - simplify unit test for the case
khoaguin
changed the title
…t and server side - remove parsing user code in local call since it was already parsed before Co-authored-by: Shubham Gupta <[email protected]>
|
Hi @IrinaMBejan, currently the fix is like below Also the way we do it now is to put the check in the |
shubham3121
requested changes
Jul 2, 2024
shubham3121
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue