Rename args in some API endpoints to be more consistent #8853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiendang
force-pushed
the
cleanup-api-args
branch
from
341d33f
to
a7be81e
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kiendang
force-pushed
the
cleanup-api-args
branch
6 times, most recently
from
64ab723
to
dc6d4cc
Compare
to be consistent with other endpoints
to be consistent with other endpoints
to avoid ambiguity
to be consistent with worker_pool_service.create_image_and_pool_request
kiendang
force-pushed
the
cleanup-api-args
branch
from
dc6d4cc
to
270d053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8802 (comment)
imagetoimage_uidinworker_image_service.pushto be consistent with other endpoints.pooltopool_nameinworker_pool_service.launch`to be consistent with other endpoints.pullinworker_image_service.buildto be consistent withworker_pool_service.create_image_and_pool_request(pull_image: bool)reg_usernameandreg_passwordtoregistry_usernameandregistry_password. The later are much clearer while not much longer. Plus we are usingregistry_uidanyway.