Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for submitting a prebuilt image #8802

Merged
merged 38 commits into from
May 27, 2024
Merged

Add support for submitting a prebuilt image #8802

merged 38 commits into from
May 27, 2024

Commits on May 13, 2024

  1. Add support for submitting a prebuilt image 

    Rename submit_dockerfile to submit_container_image

submit_container_image now accepts a docker_config of a more generic WorkerConfig type which could be DockerWorkerConfig or PrebuiltWorkerConfig

Add unit tests
    @kiendang
    kiendang committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0aa797d View commit details
    Browse the repository at this point in the history

  2. Remove the nbqa-black pre-commit hook 

    ruff has already been configured to format notebook files as well.
    @kiendang
    kiendang committed May 13, 2024
    Configuration menu
    Copy the full SHA
    870f591 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'dev' into prebuilt-image-worker

    @shubham3121
    shubham3121 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7f86a1e View commit details
    Browse the repository at this point in the history

  2. Rename get_by_docker_config to get_by_worker_config 

    get_by_worker_config now accepts a config of a more generic WorkerConfig type which could be DockerWorkerConfig or PrebuiltWorkerConfig
    @kiendang
    kiendang committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6c48218 View commit details
    Browse the repository at this point in the history

  3. Add unit test for services.worker_image.get_by_config

    @kiendang
    kiendang committed May 14, 2024
    Configuration menu
    Copy the full SHA
    85935b3 View commit details
    Browse the repository at this point in the history

  4. Rename

    @kiendang
    kiendang committed May 14, 2024
    Configuration menu
    Copy the full SHA
    81ae3ea View commit details
    Browse the repository at this point in the history

  5. Use get_by_image to retrieve the image in test

    @kiendang
    kiendang committed May 14, 2024
    Configuration menu
    Copy the full SHA
    56a8ad6 View commit details
    Browse the repository at this point in the history

  6. Rename arg docker_config to worker_config 

    in services.worker_image.submit_container_image and
services.worker_image.get_by_config
    @kiendang
    kiendang committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ce21987 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Add integration tests for prebuilt images

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    df646ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into prebuilt-image-worker

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6c13ba2 View commit details
    Browse the repository at this point in the history

  3. Fix worker pool integration tests 

    Revert to use a different dockerfile for each test
    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    16bcf91 View commit details
    Browse the repository at this point in the history

  4. Fix worker pool integration tests 

    set registry_uid
    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    87861a3 View commit details
    Browse the repository at this point in the history

  5. Use a different prebuilt image for each tag

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    749bc1e View commit details
    Browse the repository at this point in the history

  6. Add tag for images from PrebuiltWorkerConfig

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f2c4d5c View commit details
    Browse the repository at this point in the history

  7. No longer try to push prebuilt image to local registry

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9f24bab View commit details
    Browse the repository at this point in the history

  8. Use a different worker pool name for each test

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b0b658a View commit details
    Browse the repository at this point in the history

  9. Get error while launching worker pool

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    74038fe View commit details
    Browse the repository at this point in the history

  10. debug

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b9554e5 View commit details
    Browse the repository at this point in the history

  11. Increase k8s pool creation timeout

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6d6a6a6 View commit details
    Browse the repository at this point in the history

  12. Test using a smaller image

    @kiendang
    kiendang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5636bf1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Remove unused variables

    @kiendang
    kiendang committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ece69c1 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary check

    @kiendang
    kiendang committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9e84ea9 View commit details
    Browse the repository at this point in the history

  3. Use different prebuilt images for tests

    @kiendang
    kiendang committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f9a35e1 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'dev' into prebuilt-image-worker

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c67932f View commit details
    Browse the repository at this point in the history

  2. Avoid username collision in tests

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dd138f5 View commit details
    Browse the repository at this point in the history

  3. Get the correct job by id instead of the last job

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1286940 View commit details
    Browse the repository at this point in the history

  4. Only require tag for DockerWorkerConfig pool request

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7c535c7 View commit details
    Browse the repository at this point in the history

  5. Update CreateCustomImageChange protocol version

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5ecf05b View commit details
    Browse the repository at this point in the history

  6. Update tests

    @kiendang
    kiendang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    135fbb2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'dev' into prebuilt-image-worker

    @shubham3121
    shubham3121 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    54c3aed View commit details
    Browse the repository at this point in the history

  2. Return an error in case of invalid container name

    @kiendang
    kiendang committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3618ad4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'dev' into prebuilt-image-worker

    @shubham3121
    shubham3121 committed May 27, 2024
    Configuration menu
    Copy the full SHA
    39ac64a View commit details
    Browse the repository at this point in the history

  2. Rename submit_container_image to just submit

    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3cb2a0a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into prebuilt-image-worker

    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    6a7022a View commit details
    Browse the repository at this point in the history

  4. Use correct account client 

    this should be ds_client instead of domain_client
    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a8d86ed View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into prebuilt-image-worker

    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c453ad5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into prebuilt-image-worker

    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9865e20 View commit details
    Browse the repository at this point in the history

  7. Fix user permission in test

    @kiendang
    kiendang committed May 27, 2024
    Configuration menu
    Copy the full SHA
    19d627f View commit details
    Browse the repository at this point in the history