Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add antti to the list of padawans. #7563

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d5b44b1
add new tests for R3Q1
shubham3121 Jan 18, 2023
7a84531
Try upgrading tox
madhavajay Jan 22, 2023
ee21631
Added chcp to allowlist_externals in tox
madhavajay Jan 23, 2023
f27561b
padawan trial 1
Jan 24, 2023
1329765
Padawan trial 1: Added my name to skill_test.py
khoaguin Jan 25, 2023
0bd3205
Trigger CI
madhavajay Jan 25, 2023
d2aa489
Ignoring GitHub CI Setuptools version check
madhavajay Jan 25, 2023
f391d40
modified skywalker passing status
Jan 25, 2023
5b0d8d2
Trigger CI
madhavajay Jan 25, 2023
2db6803
Ignoring GitHub CI Setuptools version check
madhavajay Jan 25, 2023
3ff82bb
Merge branch 'zmz222/trial_1' of github.com:zmz223/PySyft into zmz223…
Jan 25, 2023
ff3b75c
Merge pull request #7250 from madhavajay/madhava/enable_ci
madhavajay Jan 25, 2023
48d7e66
Merge branch 'padawan_trial_1' into zmz223/trial_1
madhavajay Jan 25, 2023
32f91fb
Merge branch 'padawan_trial_1' into khoa_nguyen/trial_1
madhavajay Jan 25, 2023
0272c02
Merge pull request #7249 from zmz223/zmz223/trial_1
madhavajay Jan 25, 2023
5fa532c
Merge branch 'padawan_trial_1' into khoa_nguyen/trial_1
madhavajay Jan 25, 2023
223fb1e
merge with padawa_trial_1 and change skywalker to PASSED
khoaguin Jan 26, 2023
abe0fee
First commit in padawan programm. Added Name to SkillTest
letv3 Jan 26, 2023
f2c6ce1
Merge pull request #7256 from letv3/letv3/trial_1
bitsofsteve Jan 26, 2023
6c0cf49
merging with PySyft/padawan_trial_1
khoaguin Jan 27, 2023
d09b3ae
added my name to the 'R3Q1' dict in get_padawans function and an asse…
khoaguin Jan 27, 2023
67dd816
Merge pull request #7248 from khoaguin/khoa_nguyen/trial_1
madhavajay Jan 27, 2023
1cc6705
Add name to skill_test
thehimalayanleo Jan 27, 2023
ef406a2
Add my name to Padawans dict
jcardonnet Jan 27, 2023
ff90b56
Merge pull request #7262 from thehimalayanleo/thehimalayanleo/re_trial_1
kiendang Jan 27, 2023
a0a8c6f
Merge branch 'padawan_trial_1' into julian/trial_1
jcardonnet Jan 27, 2023
5b05025
[NEW] Add my name in R3Q1 skill_test.py
HusseinLezzaik Jan 29, 2023
6fc0b25
Added my name to padawans data in skill_test.py, bumped isort version…
onlyoneuche Jan 29, 2023
2f1f7ac
peter chung: added name to padawan_trial_1
PeterChung241 Jan 30, 2023
87bcf01
Merge pull request #7270 from PeterChung241/pete/padawan_trial_1
kiendang Jan 30, 2023
d139854
Merge branch 'padawan_trial_1' into padawan_trial_1
IonesioJunior Jan 30, 2023
cbb193a
Fixed formatting of skill_test.py file
madhavajay Jan 30, 2023
4d16c16
Upgrade isort pre-commit plugin due to error
madhavajay Jan 30, 2023
8fc5ebf
Merge pull request #7266 from HusseinLezzaik/padawan_trial_1
madhavajay Jan 30, 2023
17f75f5
Merge branch 'padawan_trial_1' into julian/trial_1
madhavajay Jan 30, 2023
d5b9ae1
Merge pull request #7268 from onlyoneuche/uche/trial_1
madhavajay Jan 30, 2023
5fa1742
Merge pull request #7267 from jcardonnet/julian/trial_1
madhavajay Jan 30, 2023
c18df3d
add padawan vani's skill test
Jan 30, 2023
dd00acb
Merge pull request #7269 from vaniisgh/vani/trial_1
madhavajay Jan 31, 2023
c53e1ce
added Hithem to skill_test
HaithemLamri Jan 31, 2023
77856f0
Merge pull request #7276 from HaithemLamri/Hithem2/trial_1
IonesioJunior Jan 31, 2023
d093c79
Add antti to the list of padawans.
akalliokoski Apr 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

- name: Install tox
run: |
pip install tox==3.27.1
pip install -U tox

- name: Install mongo tools
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/continuous-delivery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install --upgrade setuptools wheel twine bump2version PyYAML
pip install tox==3.27.1
pip install -U tox
- name: Bump the Version
run: |
ls **/VERSION | xargs -I {} python {}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: Install tox
run: |
pip install tox==3.27.1
pip install -U tox

- name: Build the docs
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/grid-backend_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.backend == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Run Backend API tests
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/grid-frontend_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.frontend == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Cache Cypress binary
if: steps.changes.outputs.frontend == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/hagrid-continuous_delivery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install --upgrade setuptools wheel twine bump2version PyYAML
pip install tox==3.27.1
pip install -U tox

- name: Bump the Version
if: ${{needs.hagrid-deploy.outputs.current_hash}} != ${{needs.hagrid-deploy.outputs.previous_hash}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/hagrid-pr_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
if: steps.changes.outputs.hagrid == 'true'
run: |
pip install --upgrade bandit safety setuptools wheel twine
pip install tox==3.27.1
pip install -U tox
pip install -e .

- name: Scan for security issues python 3.8+
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightlies-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:

- name: Install tox
run: |
pip install tox==3.27.1
pip install -U tox

- name: Install Docker Compose
if: runner.os == 'Linux'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stack-integration-arm64_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:

- name: Install tox
run: |
pip install tox==3.27.1
pip install -U tox

- name: Install Docker Compose
if: runner.os == 'Linux'
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Show choco installed packages
if: steps.changes.outputs.stack == 'true' && matrix.os == 'windows'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stack-integration-public_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:

- name: Install tox
run: |
pip install tox==3.27.1
pip install -U tox

- name: Install Docker Compose
if: runner.os == 'Linux'
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/stack-integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Show choco installed packages
if: steps.changes.outputs.stack == 'true' && matrix.os == 'windows'
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Show choco installed packages
if: steps.changes.outputs.stack == 'true' && matrix.os == 'windows'
Expand Down Expand Up @@ -411,7 +411,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Show choco installed packages
if: steps.changes.outputs.stack == 'true' && matrix.os == 'windows'
Expand Down Expand Up @@ -586,7 +586,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Show choco installed packages
if: steps.changes.outputs.stack == 'true' && matrix.os == 'windows'
Expand Down Expand Up @@ -754,7 +754,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: Install kubectl
if: steps.changes.outputs.stack == 'true'
Expand Down Expand Up @@ -918,7 +918,7 @@ jobs:
- name: Install tox
if: steps.changes.outputs.stack == 'true'
run: |
pip install tox==3.27.1
pip install -U tox

- name: docker cache
uses: actions/cache@v3
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/syft-pr_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:
- "0.6.0"
- "0.7.0"
- "0.8"
- "padawan_trial_1"
defaults:
run:
working-directory: ./packages/syft
Expand Down Expand Up @@ -84,15 +85,15 @@ jobs:
run: |
pip install importlib-metadata==4.13.0
bandit -r src
safety check -i 51668
safety check -i 51668 -i 52495

- name: Scan for security issues python 3.7
if: steps.changes.outputs.syft == 'true' && matrix.python-version == '3.7'
run: |
pip install importlib-metadata==4.13.0
bandit -r src
# we want to test python 3.7 for colab so we have to ignore these numpy issues
safety check -i 44717 -i 44716 -i 44715 -i 51668
safety check -i 44717 -i 44716 -i 44715 -i 51668 -i 52495

- name: Run normal tests
if: steps.changes.outputs.syft == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/syft-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install --upgrade setuptools wheel twine bump2version
pip install tox==3.27.1
pip install -U tox
- name: Build and publish
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ repos:
)$

- repo: https://github.com/pycqa/isort
rev: 5.10.1
rev: 5.12.0
hooks:
- id: isort
name: isort
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/ansible/roles/jupyter/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
- name: Install Tox
shell: "runuser -l {{ om_user }} -c 'pip install tox==3.27.1'"
shell: "runuser -l {{ om_user }} -c 'pip install -U tox'"
become: yes
when: vagrant is not defined and jupyter == "true"

Expand Down
40 changes: 38 additions & 2 deletions packages/syft/tests/trials/skill_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,24 @@ def get_padawans(cohort: str) -> Dict[str, str]:
"Akshay": "PASSED",
"Zarreen": "PASSED",
"Mihir": "PASSED",
}
"Uche": "PASSED",
},
"R3Q1": {
"skywalker": "PASSED",
"Zach": "PASSED",
"Oleksandr": "PASSED",
"Khoa": "PASSED",
"Julian": "PASSED",
"Ajinkya": "PASSED",
"Hussein": "PASSED",
"Peter": "PASSED",
"Vani": "PASSED",
"Hithem": "PASSED",
},
"R4Q2": {
"skywalker": "PASSED",
"antti": "PASSED",
},
}
return data[cohort]

Expand All @@ -53,5 +70,24 @@ def test_trial_of_skill() -> None:
assert get_padawans("R2Q4")["Akshay"] == "PASSED"
assert get_padawans("R2Q4")["Zarreen"] == "PASSED"
assert get_padawans("R2Q4")["Mihir"] == "PASSED"
assert get_padawans("R2Q4")["Uche"] == "PASSED"

assert len(get_padawans("R2Q4")) == 21

assert get_padawans("R3Q1")["skywalker"] == "PASSED"
assert get_padawans("R3Q1")["Zach"] == "PASSED"
assert get_padawans("R3Q1")["Oleksandr"] == "PASSED"
assert get_padawans("R3Q1")["Khoa"] == "PASSED"
assert get_padawans("R3Q1")["Julian"] == "PASSED"
assert get_padawans("R3Q1")["Ajinkya"] == "PASSED"
assert get_padawans("R3Q1")["Hussein"] == "PASSED"
assert get_padawans("R3Q1")["Peter"] == "PASSED"
assert get_padawans("R3Q1")["Vani"] == "PASSED"
assert get_padawans("R3Q1")["Hithem"] == "PASSED"

assert len(get_padawans("R3Q1")) > 1

assert get_padawans("R4Q2")["skywalker"] == "PASSED"
assert get_padawans("R4Q2")["antti"] == "PASSED"

assert len(get_padawans("R2Q4")) > 1
assert len(get_padawans("R4Q2")) > 1
13 changes: 4 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ envlist =
syft.test.fast.coverage
syft.test.security
padawan.trials
requires =
tox-run-command
pip >= 22.0.4
tox==3.27.1
skipsdist = True


Expand All @@ -41,13 +37,8 @@ allowlist_externals =
deps =
black[python2]
isort
protoc-wheel-0==3.19.4
pre-commit
commands =
pip install protoc-wheel-0==3.19.4 --force
bash -c "cd {toxinidir}/packages/syft; ./scripts/build_proto.sh"
black .
isort .
pre-commit run --all-files

[testenv:padawan.trials]
Expand Down Expand Up @@ -184,6 +175,7 @@ allowlist_externals =
grep
sleep
bash
chcp
setenv =
PIP_FIND_LINKS=https://whls.blob.core.windows.net/unstable/index.html
HAGRID_FLAGS = {env:HAGRID_FLAGS:--tag=local --test}
Expand Down Expand Up @@ -302,6 +294,7 @@ allowlist_externals =
bash
mkcert
mkdir
chcp
setenv =
PIP_FIND_LINKS=https://whls.blob.core.windows.net/unstable/index.html
HAGRID_FLAGS = {env:HAGRID_FLAGS:--tag=local --test}
Expand Down Expand Up @@ -424,6 +417,7 @@ allowlist_externals =
grep
sleep
bash
chcp
setenv =
PIP_FIND_LINKS=https://whls.blob.core.windows.net/unstable/index.html
HAGRID_FLAGS = {env:HAGRID_FLAGS:--tag=local --test}
Expand Down Expand Up @@ -528,6 +522,7 @@ allowlist_externals =
grep
sleep
bash
chcp
setenv =
PIP_FIND_LINKS=https://whls.blob.core.windows.net/unstable/index.html
HAGRID_FLAGS = {env:HAGRID_FLAGS:--tag=local --test}
Expand Down