Merge pull request #7745 from khoaguin/data_asset_id_before_upload

Showing name and shape of asset before uploading (`CreateAsset`)
OpenMined · Jun 13, 2023 · df5b027 · df5b027
2 parents e300d97 + fb6ec59
commit df5b027
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/syft/src/syft/service/dataset/dataset.py b/packages/syft/src/syft/service/dataset/dataset.py
@@ -218,6 +218,8 @@ class CreateAsset(SyftObject):
     mock_is_real: bool = False
     created_at: Optional[DateTime]
 
+    __attr_repr_cols__ = ["name"]
+
     class Config:
         validate_assignment = True
 
@@ -491,7 +493,6 @@ def add_contributor(
     def add_asset(self, asset: CreateAsset) -> None:
         if asset.mock is None:
             raise ValueError(_ASSET_WITH_NONE_MOCK_ERROR_MESSAGE)
-
         self.asset_list.append(asset)
 
     def remove_asset(self, name: str) -> None:

diff --git a/packages/syft/src/syft/types/syft_object.py b/packages/syft/src/syft/types/syft_object.py
@@ -559,7 +559,7 @@ def list_dict_repr_html(self) -> str:
 
                 # get id
                 id_ = getattr(item, "id", None)
-                if id is not None:
+                if id_ is not None:
                     id_ = f"{str(id_)[:4]}...{str(id_)[-3:]}"
 
                 if type(item) == type:
@@ -569,7 +569,9 @@ def list_dict_repr_html(self) -> str:
                         t = item.__class__.__name__
                     except Exception:
                         t = item.__repr__()
-                cols["id"].append(id_)
+                if id_ is not None:
+                    cols["id"].append(id_)
+
                 if not is_homogenous:
                     cols["type"].append(t)