Merge pull request #8825 from khoaguin/deprecate-action-graph-service

Deprecate Action Graph Service
OpenMined · May 27, 2024 · 58f2d36 · 58f2d36
2 parents 89fd464 + cb3515f
commit 58f2d36
Show file tree

Hide file tree

Showing 15 changed files with 1 addition and 2,124 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -151,7 +151,7 @@ repos:
         name: "mypy: syft"
         always_run: true
         files: "^packages/syft/src/syft/"
-        exclude: "packages/syft/src/syft/types/dicttuple.py|^packages/syft/src/syft/service/action/action_graph.py"
+        exclude: "packages/syft/src/syft/types/dicttuple.py"
         args: [
             "--follow-imports=skip",
             "--ignore-missing-imports",

diff --git a/notebooks/tutorials/data-scientist/04-action-graph.ipynb b/notebooks/tutorials/data-scientist/04-action-graph.ipynb
diff --git a/...ls/data-scientist/05-syft-functions.ipynb → ...ls/data-scientist/04-syft-functions.ipynb b/...ls/data-scientist/05-syft-functions.ipynb → ...ls/data-scientist/04-syft-functions.ipynb
diff --git a/...scientist/06-messaging-and-requests.ipynb → ...scientist/05-messaging-and-requests.ipynb b/...scientist/06-messaging-and-requests.ipynb → ...scientist/05-messaging-and-requests.ipynb
diff --git a/...s/data-scientist/07-custom-policies.ipynb → ...s/data-scientist/06-custom-policies.ipynb b/...s/data-scientist/07-custom-policies.ipynb → ...s/data-scientist/06-custom-policies.ipynb
diff --git a/packages/syft/setup.cfg b/packages/syft/setup.cfg
@@ -31,7 +31,6 @@ syft =
     boto3==1.34.56
     forbiddenfruit==0.1.4
     loguru==0.7.2
-    networkx==3.2.1
     packaging>=23.0
     pyarrow==15.0.0
     # pycapnp is beta version, update to stable version when available

diff --git a/packages/syft/src/syft/serde/third_party.py b/packages/syft/src/syft/serde/third_party.py
@@ -10,8 +10,6 @@
 from dateutil import parser
 from nacl.signing import SigningKey
 from nacl.signing import VerifyKey
-import networkx as nx
-from networkx import DiGraph
 import numpy as np
 from pandas import DataFrame
 from pandas import Series
@@ -229,24 +227,6 @@ def torch_deserialize(buffer: bytes) -> torch.tensor:
 # how else do you import a relative file to execute it?
 NOTHING = None
 
-
-# TODO: debug serializing after updating a node
-def serialize_networkx_graph(graph: DiGraph) -> bytes:
-    graph_dict: dict = nx.node_link_data(graph)
-    return serialize(graph_dict, to_bytes=True)
-
-
-def deserialize_networkx_graph(buf: bytes) -> DiGraph:
-    graph_dict: dict = deserialize(buf, from_bytes=True)
-    return nx.node_link_graph(graph_dict)
-
-
-recursive_serde_register(
-    DiGraph,
-    serialize=serialize_networkx_graph,
-    deserialize=deserialize_networkx_graph,
-)
-
 try:
     # Just register these serializers if the google.cloud.bigquery & db_dtypes module are available
     # third party